Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): hidden values do not take effect when us… #3228

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Gggpound
Copy link
Contributor

…ed with data validation

close https://github.com/dream-num/univer-pro/issues/1888

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.84%. Comparing base (f1a45fd) to head (98e62f4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...validation/src/controllers/dv-render.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3228      +/-   ##
==========================================
- Coverage   29.84%   29.84%   -0.01%     
==========================================
  Files        2051     2051              
  Lines      109053   109054       +1     
  Branches    23712    23713       +1     
==========================================
  Hits        32548    32548              
- Misses      76505    76506       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound merged commit 4e888d0 into dev Aug 30, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-cf-0828 branch August 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants