Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): dialog close all #3240

Merged
merged 3 commits into from
Aug 29, 2024
Merged

feat(sheet): dialog close all #3240

merged 3 commits into from
Aug 29, 2024

Conversation

VicKun4937
Copy link
Contributor

  • add close all function in dialog service

Copy link

github-actions bot commented Aug 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (5fd5350) to head (773a712).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...s/ui/src/services/dialog/desktop-dialog.service.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3240      +/-   ##
==========================================
- Coverage   28.55%   28.55%   -0.01%     
==========================================
  Files        2022     2022              
  Lines      106837   106842       +5     
  Branches    23110    23111       +1     
==========================================
- Hits        30509    30507       -2     
- Misses      76328    76335       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit f06192d into dev Aug 29, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the feat-dialog-close-all branch August 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants