Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix formula paste #3257

Merged
merged 6 commits into from
Aug 31, 2024
Merged

fix(formula): fix formula paste #3257

merged 6 commits into from
Aug 31, 2024

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Aug 30, 2024

close https://github.com/dream-num/univer-pro/issues/1665
close https://github.com/dream-num/univer-pro/issues/1355

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 28.10458% with 110 lines in your changes missing coverage. Please review.

Project coverage is 29.82%. Comparing base (4936567) to head (a0469ee).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...la/src/controllers/formula-clipboard.controller.ts 28.10% 110 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3257      +/-   ##
==========================================
- Coverage   29.85%   29.82%   -0.03%     
==========================================
  Files        2051     2051              
  Lines      109189   109280      +91     
  Branches    23742    23752      +10     
==========================================
- Hits        32594    32590       -4     
- Misses      76595    76690      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:rejected qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested qa:rejected labels Aug 31, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants