Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): auto-fill will copy auto-height strategy from origin region #3287

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Sep 2, 2024

close https://github.com/dream-num/univer-pro/issues/1264

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 3, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (c29fa22) to head (c80fda7).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/services/auto-fill/auto-fill.service.ts 75.75% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3287      +/-   ##
==========================================
+ Coverage   30.18%   30.19%   +0.01%     
==========================================
  Files        2112     2112              
  Lines      109767   109793      +26     
  Branches    23870    23876       +6     
==========================================
+ Hits        33132    33155      +23     
- Misses      76635    76638       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz merged commit 04f156e into dev Sep 5, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/fix-autofill-autoheight branch September 5, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants