Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add merge facade api #3289

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat(facade): add merge facade api #3289

merged 5 commits into from
Sep 4, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 2, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 2, 2024

View Deployment

#10696048734

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 17.07317% with 34 lines in your changes missing coverage. Please review.

Project coverage is 30.09%. Comparing base (a2be933) to head (86b9bec).
Report is 33 commits behind head on dev.

Files with missing lines Patch % Lines
packages/facade/src/apis/sheets/f-range.ts 17.39% 19 Missing ⚠️
...c/commands/commands/add-worksheet-merge.command.ts 0.00% 13 Missing ⚠️
...ommands/commands/remove-worksheet-merge.command.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3289      +/-   ##
==========================================
+ Coverage   29.84%   30.09%   +0.24%     
==========================================
  Files        2051     2109      +58     
  Lines      109053   109719     +666     
  Branches    23712    23852     +140     
==========================================
+ Hits        32548    33015     +467     
- Misses      76505    76704     +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexf00
Copy link
Member

hexf00 commented Sep 2, 2024

It is recommended to implement the following API as defined below.
Facade should be easy to use and reduce the appearance of IRange

Add an example (Office Script design) to explain why there is a merge API on Range
https://learn.microsoft.com/zh-cn/javascript/api/office-scripts/excelscript/excelscript.range?view=office-scripts#excelscript-excelscript-range-getmergedareas-member(1)

@hexf00 hexf00 changed the title chore: add merge facade api feat(facade): add merge facade api Sep 4, 2024
Copy link
Member

@hexf00 hexf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybzky ybzky merged commit acd03e4 into dev Sep 4, 2024
10 checks passed
@ybzky ybzky deleted the feat-add-merge-facade branch September 4, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants