Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clipboard): copy will not use filtered-out rows content #3292

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Sep 2, 2024

close https://github.com/dream-num/univer-pro/issues/1266

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.25%. Comparing base (965064e) to head (0f32ff7).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...ui/src/services/clipboard/usm-to-html/convertor.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3292      +/-   ##
==========================================
+ Coverage   29.85%   30.25%   +0.40%     
==========================================
  Files        2038     2039       +1     
  Lines      109276   109346      +70     
  Branches    23769    23782      +13     
==========================================
+ Hits        32624    33085     +461     
+ Misses      76652    76261     -391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz requested review from jikkai and wzhudev and removed request for jikkai September 3, 2024 06:42
@yuhongz
Copy link
Contributor Author

yuhongz commented Sep 3, 2024

This case was covered by test @wzhudev

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhongz yuhongz merged commit ec601c3 into dev Sep 4, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/fix-copypaste-filter branch September 4, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants