Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip invisible row in filtered state for performance #3319

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 4, 2024

close #3313

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.18%. Comparing base (3f18a4f) to head (508aed6).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3319      +/-   ##
==========================================
- Coverage   30.18%   30.18%   -0.01%     
==========================================
  Files        2112     2112              
  Lines      109760   109762       +2     
  Branches    23859    23860       +1     
==========================================
  Hits        33132    33132              
- Misses      76628    76630       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku changed the title fix: skip invisible row after filter fix: skip invisible row in filtered state Sep 4, 2024
@lumixraku lumixraku changed the title fix: skip invisible row in filtered state fix: skip invisible row in filtered state for performance Sep 5, 2024
@oumomomo oumomomo removed the qa:untested This PR is ready to be tested label Sep 5, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit 5ada754 into dev Sep 5, 2024
11 checks passed
@lumixraku lumixraku deleted the fix/filter-render-performance branch September 5, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Scroll freeze on filtering large data
3 participants