Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet-data-validation): auto-format data validation non-standard date string & data-validation auto-fill #3336

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 5, 2024

close https://github.com/dream-num/univer-pro/issues/2352
close https://github.com/dream-num/univer-pro/issues/2344
close https://github.com/dream-num/univer-pro/issues/2283

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner September 5, 2024 11:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (5ab492f) to head (f30b787).
Report is 15 commits behind head on dev.

Files with missing lines Patch % Lines
...s-data-validation/src/validators/date-validator.ts 0.00% 18 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 6 Missing ⚠️
...idation/src/controllers/dv-auto-fill.controller.ts 0.00% 3 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 2 Missing ⚠️
...a-validation/src/validators/base-data-validator.ts 0.00% 2 Missing ⚠️
...n/src/views/formula-input/custom-formula-input.tsx 0.00% 1 Missing ⚠️
...ion/src/views/formula-input/list-formula-input.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3336   +/-   ##
=======================================
  Coverage   30.18%   30.19%           
=======================================
  Files        2112     2112           
  Lines      109767   109822   +55     
  Branches    23870    23888   +18     
=======================================
+ Hits        33132    33158   +26     
- Misses      76635    76664   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

oumomomo commented Sep 5, 2024

修改引用数据内的应用范围后无法保存
步骤:
1、进入下拉菜单-引用数据设置引用范围后点击确认
2、再次进入刚刚设置的下拉菜单面板,在引用范围后输入,点击确认
3、删除引用范围后的,点击保存

实际结果:错误提示一直在,无法保存
image
2024_9_5 19_36_05 video.webm

@univer-bot
Copy link

univer-bot bot commented Sep 5, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Unable to save after modifying the application scope in the reference data
step:

  1. Enter the drop-down menu - Reference data, set the reference range and click OK.
  2. Enter the drop-down menu panel you just set again, enter after the reference range, and click Confirm
  3. After deleting the reference range, click Save

Actual result: The error message remains and cannot be saved.
image
2024_9_5 19_36_05 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 5, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 6, 2024
@univer-bot univer-bot bot removed the qa:rejected label Sep 6, 2024
@weird94 weird94 merged commit fc3dc44 into dev Sep 6, 2024
16 checks passed
@weird94 weird94 deleted the fix/data-validation-date branch September 6, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants