fix(sheet): merge cell custom property #3365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3346What has changed?
cell.custom
used to overwrite the entire thing, causing the original custom to be lost. Now it has been fixed to be similar tocell style
, and needs to be merged when updatingcell.custom
(one-layer merge)How to test?
univerAPI.getActiveWorkbook().getActiveSheet().getRange(0,0,1,1).setValue({custom:{a:1}})
univer._univerInstanceService.getFocusedUnit()._snapshot
univerAPI.getActiveWorkbook().getActiveSheet().getRange(0,0,1,1).setValue({custom:{b:1}})
Pull Request Checklist