Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add function mid #3417

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat(formula): add function mid #3417

merged 3 commits into from
Sep 19, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Sep 12, 2024

close #2735

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir changed the title feat(formula): add MID function implementation #2735 feat(formula): add MID function implementation Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 12, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  4f167e3
info  For more information, see full report

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.81%. Comparing base (b66e8ce) to head (4f167e3).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/engine-formula/src/functions/text/mid/index.ts 89.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3417      +/-   ##
==========================================
+ Coverage   30.78%   30.81%   +0.03%     
==========================================
  Files        2157     2158       +1     
  Lines      113176   113230      +54     
  Branches    24812    24837      +25     
==========================================
+ Hits        34844    34897      +53     
- Misses      78332    78333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Sep 12, 2024
@Dushusir Dushusir marked this pull request as ready for review September 12, 2024 12:59
@Dushusir Dushusir changed the title feat(formula): add MID function implementation feat(formula): add function mid Sep 12, 2024
@oumomomo
Copy link

oumomomo commented Sep 13, 2024

1、单元格内输入=MID("Fluid Flow",20,5),计算结果预期为空
image
image

2、单元格内输入=TEXT(MID(A2,7,8),"0000年00月00日"),计算结果预期为空?
image

3、单元格内输入=TEXT(MID(A1,7,8),"0000年00月00日") ,计算结果格式不对
A1=13607241990121222341990年12月12日
image

@univer-bot
Copy link

univer-bot bot commented Sep 13, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

  1. Enter =MID("Fluid Flow",20,5) in the cell, and the calculation result is expected to be empty.
    image
    image

  2. Enter =TEXT(MID(A2,7,8),"0000年00月00日") in the cell. Is the calculation result expected to be empty?
    image

  3. Enter =TEXT(MID(A1,7,8),"0000年00月00日") in the cell, and the calculation result format is incorrect.
    A1=1360724199012122234 December 12, 1990
    image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 13, 2024
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:rejected labels Sep 14, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Sep 18, 2024
@Dushusir Dushusir merged commit 32fb95e into dev Sep 19, 2024
9 checks passed
@Dushusir Dushusir deleted the feat/formula-mid branch September 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Text Formula MID
3 participants