Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): data validation optimize #3422

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 12, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 12, 2024

View Deployment

#10924178007

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

github-actions bot commented Sep 12, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  957301e
info  For more information, see full report

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@3cf7b46). Learn more about missing BASE report.
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...s-data-validation/src/validators/list-validator.ts 0.00% 9 Missing ⚠️
...validation/src/controllers/dv-render.controller.ts 0.00% 5 Missing ⚠️
...ta-validation/src/validators/checkbox-validator.ts 0.00% 2 Missing ⚠️
...a-validation/src/validators/base-data-validator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #3422   +/-   ##
======================================
  Coverage       ?   30.67%           
======================================
  Files          ?     2155           
  Lines          ?   113035           
  Branches       ?    24770           
======================================
  Hits           ?    34671           
  Misses         ?    78364           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 93c3659 into dev Sep 18, 2024
8 of 9 checks passed
@weird94 weird94 deleted the feat/data-validation-optimize branch September 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants