Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll cmd for pointer down at scrolltrack #3429

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 13, 2024

close #3191

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 13, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  56cdf4e
info  For more information, see full report

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 2.94118% with 132 lines in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (4b86a65) to head (56cdf4e).
Report is 44 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/shape/scroll-bar.ts 0.00% 64 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 55 Missing ⚠️
...ackages/engine-render/src/shape/base-scroll-bar.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 3 Missing ⚠️
...der-controllers/header-resize.render-controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3429   +/-   ##
=======================================
  Coverage   30.59%   30.59%           
=======================================
  Files        2156     2156           
  Lines      112917   112909    -8     
  Branches    24764    24761    -3     
=======================================
  Hits        34546    34546           
+ Misses      78371    78363    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/scroll-cmd-scrolltrack branch from dddcb7e to 243db1d Compare September 13, 2024 09:35
@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Sep 13, 2024
@lumixraku lumixraku force-pushed the fix/scroll-cmd-scrolltrack branch from 243db1d to ebc1e26 Compare September 13, 2024 11:21
@lumixraku lumixraku force-pushed the fix/scroll-cmd-scrolltrack branch from ebc1e26 to 56cdf4e Compare September 14, 2024 07:08
@lumixraku lumixraku self-assigned this Sep 14, 2024
@wzhudev wzhudev merged commit 8e9f513 into dev Sep 21, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/scroll-cmd-scrolltrack branch September 21, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No scroll event is triggered when clicking on the scroll bar in Sheets
2 participants