Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add support for dynamic imports #3433

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat(demo): add support for dynamic imports #3433

merged 2 commits into from
Sep 13, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  693f63a
info  For more information, see full report

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 30.52%. Comparing base (f042ec2) to head (693f63a).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages-experimental/action-recorder/src/plugin.ts 0.00% 8 Missing ⚠️
...l/action-recorder/src/controllers/config.schema.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3433      +/-   ##
==========================================
- Coverage   30.52%   30.52%   -0.01%     
==========================================
  Files        2156     2157       +1     
  Lines      112870   112879       +9     
  Branches    24744    24746       +2     
==========================================
  Hits        34458    34458              
- Misses      78412    78421       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai changed the title Chore/splitting feat(demo): add support for dynamic imports Sep 13, 2024
@jikkai jikkai marked this pull request as ready for review September 13, 2024 09:41
@jikkai jikkai merged commit 33571b6 into dev Sep 13, 2024
9 of 10 checks passed
@jikkai jikkai deleted the chore/splitting branch September 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant