Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): getDiscreteRanges filter empty cell #3437

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Sep 13, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 13, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  35ae99e
info  For more information, see full report

@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.56%. Comparing base (0d437d3) to head (35ae99e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3437      +/-   ##
==========================================
+ Coverage   30.55%   30.56%   +0.01%     
==========================================
  Files        2156     2156              
  Lines      112881   112881              
  Branches    24747    24747              
==========================================
+ Hits        34486    34505      +19     
+ Misses      78395    78376      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as draft September 13, 2024 22:08
@Dushusir Dushusir marked this pull request as ready for review September 14, 2024 02:50
@Dushusir Dushusir merged commit 92a063a into dev Sep 14, 2024
10 checks passed
@Dushusir Dushusir deleted the fix/object-matrix branch September 14, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant