Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add FWorksheet.getRange(a1Notation) #3504

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Sep 20, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  18ec411
info  For more information, see full report

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.94%. Comparing base (c4601a0) to head (18ec411).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/facade/src/apis/sheets/f-worksheet.ts 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3504   +/-   ##
=======================================
  Coverage   30.93%   30.94%           
=======================================
  Files        2159     2159           
  Lines      113356   113371   +15     
  Branches    24864    24873    +9     
=======================================
+ Hits        35065    35078   +13     
- Misses      78291    78293    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hexf00 hexf00 merged commit a697a49 into dev Sep 20, 2024
9 checks passed
@hexf00 hexf00 deleted the feat/add-get-range-a1-notation branch September 20, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants