-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs-ui): paste link on link #3518
Conversation
View Deployment
|
Playwright test resultsDetails 4 tests across 2 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3518 +/- ##
==========================================
- Coverage 30.90% 30.90% -0.01%
==========================================
Files 2161 2161
Lines 113489 113493 +4
Branches 24887 24888 +1
==========================================
+ Hits 35078 35079 +1
- Misses 78411 78414 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/docs-ui/src/commands/commands/clipboard.inner.command.ts
Outdated
Show resolved
Hide resolved
@@ -31,8 +32,11 @@ export const SetZoomRatioOperation: IOperation<ISetZoomRatioOperationParams> = { | |||
handler: (accessor, params: ISetZoomRatioOperationParams) => { | |||
const renderManagerService = accessor.get(IRenderManagerService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个需要在源头阻止操作的生成,担心在 live share 场景下会有问题:本地虽然没有缩放但是 follower 缩放了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉编辑的时候很多操作都应该阻止,不仅仅是缩放
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前编辑器好多bug都和在编辑态时,用户做了其他一些操作导致的,比如切换 sheet,放大缩小等。编辑cell和这些操作不能并行,要么关闭编辑器要么阻止操作?
close https://github.com/dream-num/univer-pro/issues/2552
close https://github.com/dream-num/univer-pro/issues/2293
close https://github.com/dream-num/univer-pro/issues/1992
close https://github.com/dream-num/univer-pro/issues/1620
Pull Request Checklist