Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): paste link on link #3518

Merged
merged 5 commits into from
Sep 21, 2024
Merged

fix(docs-ui): paste link on link #3518

merged 5 commits into from
Sep 21, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 21, 2024

close https://github.com/dream-num/univer-pro/issues/2552
close https://github.com/dream-num/univer-pro/issues/2293
close https://github.com/dream-num/univer-pro/issues/1992
close https://github.com/dream-num/univer-pro/issues/1620

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 21, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  a350669
info  For more information, see full report

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (ae8c940) to head (a350669).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/commands/operations/set-zoom-ratio.operation.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3518      +/-   ##
==========================================
- Coverage   30.90%   30.90%   -0.01%     
==========================================
  Files        2161     2161              
  Lines      113489   113493       +4     
  Branches    24887    24888       +1     
==========================================
+ Hits        35078    35079       +1     
- Misses      78411    78414       +3     
Flag Coverage Δ
30.90% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 21, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 21, 2024
@weird94 weird94 merged commit 9fcd45b into dev Sep 21, 2024
9 checks passed
@weird94 weird94 deleted the fix/doc-0921 branch September 21, 2024 09:01
@@ -31,8 +32,11 @@ export const SetZoomRatioOperation: IOperation<ISetZoomRatioOperationParams> = {
handler: (accessor, params: ISetZoomRatioOperationParams) => {
const renderManagerService = accessor.get(IRenderManagerService);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要在源头阻止操作的生成,担心在 live share 场景下会有问题:本地虽然没有缩放但是 follower 缩放了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉编辑的时候很多操作都应该阻止,不仅仅是缩放

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前编辑器好多bug都和在编辑态时,用户做了其他一些操作导致的,比如切换 sheet,放大缩小等。编辑cell和这些操作不能并行,要么关闭编辑器要么阻止操作?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants