Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protect): fix protect performance #3520

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

VicKun4937
Copy link
Contributor

  • fix performance issue for get cell

Copy link

github-actions bot commented Sep 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@VicKun4937 VicKun4937 merged commit d8b9271 into dev Sep 21, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-protect-performance branch September 21, 2024 10:02
Copy link

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 24 seconds
commit  ce3a284
info  For more information, see full report

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (de7e8b7) to head (ce3a284).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../sheets/src/model/range-protection-render.model.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3520   +/-   ##
=======================================
  Coverage   30.90%   30.90%           
=======================================
  Files        2161     2161           
  Lines      113497   113497           
  Branches    24889    24889           
=======================================
  Hits        35079    35079           
  Misses      78418    78418           
Flag Coverage Δ
30.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants