Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix display values for certain menu items #3522

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 21, 2024

close https://github.com/dream-num/univer-pro/issues/2588

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  81289d9
info  For more information, see full report

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (d8b9271) to head (81289d9).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/ui/src/components/custom-label/CustomLabel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3522      +/-   ##
==========================================
- Coverage   30.90%   30.90%   -0.01%     
==========================================
  Files        2161     2161              
  Lines      113497   113498       +1     
  Branches    24889    24889              
==========================================
  Hits        35079    35079              
- Misses      78418    78419       +1     
Flag Coverage Δ
30.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Sep 21, 2024
@jikkai jikkai merged commit 3035e39 into dev Sep 21, 2024
9 checks passed
@jikkai jikkai deleted the fix/menu-display branch September 21, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants