Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix horizontal merge wrong value #3545

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: fix horizontal merge wrong value #3545

merged 2 commits into from
Sep 24, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 24, 2024

close https://github.com/dream-num/univer-pro/issues/2540

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 24, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  c6255f7
info  For more information, see full report

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.94%. Comparing base (543ade1) to head (c6255f7).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3545      +/-   ##
==========================================
- Coverage   30.94%   30.94%   -0.01%     
==========================================
  Files        2161     2161              
  Lines      113558   113569      +11     
  Branches    24891    24894       +3     
==========================================
+ Hits        35146    35148       +2     
- Misses      78412    78421       +9     
Flag Coverage Δ
30.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VicKun4937 VicKun4937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god job

@ybzky ybzky force-pushed the fix-merge-horizontal branch from 88e505a to 80de54e Compare September 24, 2024 03:48
@zhaolixin7
Copy link

合并后值消失了
2024_9_24 11_55_25 video.webm

@univer-bot
Copy link

univer-bot bot commented Sep 24, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

The value disappears after merging
2024_9_24 11_55_25 video.webm

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 24, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 24, 2024
@ybzky ybzky merged commit b1ea6c3 into dev Sep 24, 2024
9 checks passed
@ybzky ybzky deleted the fix-merge-horizontal branch September 24, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants