Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add facade for freeze and getCellData #3561

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 24, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 24, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 3 seconds
commit  593ef77
info  For more information, see full report

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (741665c) to head (593ef77).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
packages/facade/src/apis/sheets/f-range.ts 0.00% 9 Missing ⚠️
packages/facade/src/apis/sheets/f-workbook.ts 0.00% 4 Missing ⚠️
packages/facade/src/apis/sheets/f-worksheet.ts 91.66% 2 Missing ⚠️
...src/commands/commands/set-frozen-cancel.command.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3561      +/-   ##
==========================================
+ Coverage   30.94%   31.84%   +0.90%     
==========================================
  Files        2161     2194      +33     
  Lines      113569   115234    +1665     
  Branches    24894    25378     +484     
==========================================
+ Hits        35148    36702    +1554     
- Misses      78421    78532     +111     
Flag Coverage Δ
31.84% <62.79%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hexf00 hexf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes

@hexf00 hexf00 marked this pull request as draft September 25, 2024 07:38
@hexf00
Copy link
Member

hexf00 commented Sep 25, 2024

I'll add
setFrozenColumns(columns) void Freezes the given number of columns.
setFrozenRows(rows) void Freezes the given number of rows.
getFrozenColumns() Integer Returns the number of frozen columns.
getFrozenRows() Integer Returns the number of frozen rows.

@hexf00 hexf00 marked this pull request as ready for review September 25, 2024 08:34
@weird94 weird94 merged commit 983ad9f into dev Sep 25, 2024
9 checks passed
@weird94 weird94 deleted the feat/facade-freeze branch September 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants