Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): revert column width input to initial value on menu close #3562

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 24, 2024

close https://github.com/dream-num/univer-pro/issues/2282

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested review from wzhudev and Jocs as code owners September 24, 2024 13:10
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 3 seconds
commit  0447b0e
info  For more information, see full report

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 30.94%. Comparing base (741665c) to head (0447b0e).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/views/components/context-menu/ContextMenu.tsx 0.00% 5 Missing ⚠️
...i/src/components/menu-item-input/MenuItemInput.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3562      +/-   ##
==========================================
- Coverage   30.94%   30.94%   -0.01%     
==========================================
  Files        2161     2161              
  Lines      113569   113575       +6     
  Branches    24894    24895       +1     
==========================================
  Hits        35148    35148              
- Misses      78421    78427       +6     
Flag Coverage Δ
30.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 25, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Sep 25, 2024
@jikkai jikkai merged commit 3cc2392 into dev Sep 25, 2024
9 checks passed
@jikkai jikkai deleted the fix/context-menu branch September 25, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants