Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize split into grid function #3565

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 24, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner September 24, 2024 16:25
Copy link

github-actions bot commented Sep 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 24, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 4 seconds
commit  135f147
info  For more information, see full report

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.84%. Comparing base (2506c3a) to head (135f147).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3565   +/-   ##
=======================================
  Coverage   31.84%   31.84%           
=======================================
  Files        2194     2194           
  Lines      115185   115189    +4     
  Branches    25376    25378    +2     
=======================================
+ Hits        36678    36682    +4     
  Misses      78507    78507           
Flag Coverage Δ
31.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 4e8d9a5 into dev Sep 25, 2024
9 checks passed
@weird94 weird94 deleted the feat/optimize-split-into-grid branch September 25, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants