Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add before render hook #3576

Merged
merged 3 commits into from
Sep 25, 2024
Merged

feat: add before render hook #3576

merged 3 commits into from
Sep 25, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 25, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 4 seconds
commit  69f1079
info  For more information, see full report

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (b0a23bd) to head (69f1079).
Report is 24 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/scene.ts 0.00% 3 Missing ⚠️
packages/network/src/services/http/headers.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3576      +/-   ##
==========================================
+ Coverage   30.94%   31.84%   +0.90%     
==========================================
  Files        2161     2194      +33     
  Lines      113558   115190    +1632     
  Branches    24891    25369     +478     
==========================================
+ Hits        35138    36680    +1542     
- Misses      78420    78510      +90     
Flag Coverage Δ
31.84% <0.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit e8f113e into dev Sep 25, 2024
9 checks passed
@lumixraku lumixraku deleted the chore/add-header-set branch September 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants