Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing-ui): float-dom error on scale #3612

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 27, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  7 passed
flaky  1 flaky

Details

stats  8 tests across 3 suites
duration  2 minutes, 39 seconds
commit  8d71ab9
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.87%. Comparing base (1113984) to head (8d71ab9).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3612      +/-   ##
==========================================
- Coverage   31.87%   31.87%   -0.01%     
==========================================
  Files        2193     2193              
  Lines      115294   115295       +1     
  Branches    25402    25402              
==========================================
  Hits        36745    36745              
- Misses      78549    78550       +1     
Flag Coverage Δ
31.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 5621216 into dev Sep 28, 2024
9 checks passed
@weird94 weird94 deleted the fix/float-dom-scale branch September 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants