Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bg border return before getCell #3623

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 28, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 12 seconds
commit  80411e0
info  For more information, see full report

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (1964a4c) to head (80411e0).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3623      +/-   ##
==========================================
- Coverage   31.87%   31.81%   -0.06%     
==========================================
  Files        2193     2194       +1     
  Lines      115294   115517     +223     
  Branches    25402    25435      +33     
==========================================
+ Hits        36745    36747       +2     
- Misses      78549    78770     +221     
Flag Coverage Δ
31.81% <51.16%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/skeleton-bgborder-return branch from db81078 to cfd6931 Compare September 28, 2024 11:48
@lumixraku lumixraku changed the title chore: rename fix: bg border return before getCell Sep 28, 2024
@lumixraku lumixraku requested review from VicKun4937 and removed request for VicKun4937 September 28, 2024 12:03
@lumixraku lumixraku force-pushed the fix/skeleton-bgborder-return branch from cfd6931 to 0f10652 Compare September 29, 2024 02:37
@lumixraku lumixraku merged commit 2e7b201 into dev Sep 29, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/skeleton-bgborder-return branch September 29, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants