Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): remove useless mark dirty on data-validation & thread-comment #3639

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 29, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 changed the title fix(sheets-ui): remove useless mark dirty fix(sheets-ui): remove useless mark dirty on data-validation & thread-comment Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 29, 2024

Playwright test results

passed  7 passed
flaky  1 flaky

Details

stats  8 tests across 3 suites
duration  2 minutes, 40 seconds
commit  0430b6b
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 31.83%. Comparing base (d0a9f24) to head (0430b6b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ontrollers/render-controllers/render.controller.ts 0.00% 3 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 2 Missing ⚠️
packages/sheets-hyper-link-ui/src/plugin.ts 0.00% 2 Missing ⚠️
...ontrollers/render-controllers/render.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3639      +/-   ##
==========================================
+ Coverage   31.82%   31.83%   +0.01%     
==========================================
  Files        2194     2194              
  Lines      115573   115518      -55     
  Branches    25453    25443      -10     
==========================================
  Hits        36776    36776              
+ Misses      78797    78742      -55     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The code looks much cleaner now. 👍

@wzhudev wzhudev merged commit 6b48993 into dev Oct 8, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/remove-mark-dirty branch October 8, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants