Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merged cell bg not fully ender #3671

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix: merged cell bg not fully ender #3671

merged 4 commits into from
Oct 11, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Oct 9, 2024

close https://github.com/dream-num/univer-pro/issues/2716
close #3661
close #3704

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 9, 2024

Playwright test results

passed  16 passed

Details

stats  16 tests across 8 suites
duration  3 minutes, 59 seconds
commit  190dba2
info  For more information, see full report

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 105 lines in your changes missing coverage. Please review.

Project coverage is 31.25%. Comparing base (e8ffd23) to head (190dba2).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...ne-render/src/components/sheets/extensions/font.ts 0.00% 57 Missing ⚠️
...der/src/components/sheets/extensions/background.ts 0.00% 33 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 13 Missing ⚠️
packages/core/src/sheets/span-model.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3671      +/-   ##
==========================================
+ Coverage   31.13%   31.25%   +0.11%     
==========================================
  Files        2254     2259       +5     
  Lines      116685   117125     +440     
  Branches    25642    25761     +119     
==========================================
+ Hits        36326    36603     +277     
- Misses      80359    80522     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

oumomomo commented Oct 9, 2024

CRTL+A选中所有单元格设置背景色,再合并所有单元格不展示背景色
2024_10_9 20_44_20 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 9, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

CRTL+A selects all cells to set the background color, then merges all cells without displaying the background color
2024_10_9 20_44_20 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 9, 2024
@lumixraku lumixraku force-pushed the fix/v-bg branch 3 times, most recently from 0f70f48 to 4eb03ad Compare October 10, 2024 08:13
@lumixraku lumixraku force-pushed the fix/v-bg branch 6 times, most recently from 899bd3b to 9330249 Compare October 10, 2024 12:01
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 10, 2024
@univer-bot univer-bot bot removed the qa:rejected label Oct 10, 2024
@lumixraku lumixraku changed the title fix: merged cell bg not render fix: merged cell bg not fully ender Oct 10, 2024
fix: improve bg ext performance

fix: topleft of merged cell may be null
@lumixraku lumixraku force-pushed the fix/v-bg branch 4 times, most recently from 3ae7272 to e2d5399 Compare October 11, 2024 07:23
Copy link
Contributor

@VicKun4937 VicKun4937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku force-pushed the fix/v-bg branch 2 times, most recently from 21f84f5 to 5ca2a9d Compare October 11, 2024 07:58
chore(snapshots): update snapshots
@lumixraku lumixraku merged commit 5bbbec3 into dev Oct 11, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/v-bg branch October 11, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants