Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): support database-related formulas #3749

Merged
merged 7 commits into from
Oct 19, 2024

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Oct 14, 2024

close https://github.com/dream-num/univer-pro/issues/2838

The following formulas have been added:

  • DAVERAGE
  • DCOUNT
  • DCOUNTA
  • DGET
  • DMAX
  • DMIN
  • DPRODUCT
  • DSTDEV
  • DSTDEVP
  • DSUM
  • DVAR
  • DVARP

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 14, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 6 seconds
commit  990cceb
info  For more information, see full report

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 98.09976% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.07%. Comparing base (b0c5f13) to head (990cceb).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-formula/src/basics/database.ts 93.85% 7 Missing ⚠️
...ine-formula/src/functions/database/function-map.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3749      +/-   ##
==========================================
+ Coverage   31.83%   32.07%   +0.24%     
==========================================
  Files        2309     2322      +13     
  Lines      119802   120220     +418     
  Branches    26497    26603     +106     
==========================================
+ Hits        38136    38561     +425     
+ Misses      81666    81659       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 18, 2024
@jikkai jikkai changed the title feat(formula): add some database formulas feat(formula): support database-related formulas Oct 18, 2024
@wpxp123456 wpxp123456 force-pushed the feat/add-database-func branch 2 times, most recently from 30c4d01 to abb6122 Compare October 18, 2024 12:53
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 19, 2024
@univer-bot univer-bot bot removed the qa:rejected label Oct 19, 2024
@wpxp123456 wpxp123456 merged commit 3b8af5a into dev Oct 19, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/add-database-func branch October 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants