Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh selection when collapsed #3761

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: refresh selection when collapsed #3761

merged 1 commit into from
Oct 15, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 15, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 7 seconds
commit  d2ee0db
info  For more information, see full report

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (e16ead3) to head (d2ee0db).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...services/selection/doc-selection-render.service.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3761      +/-   ##
==========================================
- Coverage   31.00%   30.97%   -0.03%     
==========================================
  Files        2280     2281       +1     
  Lines      118356   118458     +102     
  Branches    26088    26112      +24     
==========================================
  Hits        36693    36693              
- Misses      81663    81765     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review October 15, 2024 11:23
@Jocs Jocs requested a review from jikkai as a code owner October 15, 2024 11:23
@Jocs Jocs merged commit a92a389 into dev Oct 15, 2024
13 checks passed
@Jocs Jocs deleted the fix/selection-range branch October 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants