Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): reduce icon map size #3769

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound force-pushed the fix-reduce-icon-size-1016 branch from e32e2c3 to 371bcdc Compare October 16, 2024 06:37
Copy link

github-actions bot commented Oct 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound added the qa:untested This PR is ready to be tested label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 19 seconds
commit  371bcdc
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (1db5bd0) to head (371bcdc).

Files with missing lines Patch % Lines
...eets-conditional-formatting/scripts/build-icons.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3769   +/-   ##
=======================================
  Coverage   30.97%   30.97%           
=======================================
  Files        2281     2281           
  Lines      118484   118481    -3     
  Branches    26122    26122           
=======================================
  Hits        36703    36703           
+ Misses      81781    81778    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 16, 2024
@Gggpound
Copy link
Contributor Author

/update-snapshots

@Gggpound Gggpound merged commit 0f19fc0 into dev Oct 16, 2024
2 checks passed
@Gggpound Gggpound deleted the fix-reduce-icon-size-1016 branch October 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants