Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): can't save first edit cell #3781

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 17, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from Jocs as a code owner October 17, 2024 08:01
Copy link

github-actions bot commented Oct 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit d29da2f into dev Oct 17, 2024
8 of 9 checks passed
@weird94 weird94 deleted the fix/first-edit-cant-save branch October 17, 2024 08:04
Copy link

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 33 seconds
commit  9253157
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (4008c86) to head (9253157).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3781      +/-   ##
==========================================
- Coverage   30.96%   30.96%   -0.01%     
==========================================
  Files        2286     2286              
  Lines      118591   118600       +9     
  Branches    26128    26129       +1     
==========================================
  Hits        36726    36726              
- Misses      81865    81874       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants