-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sheets): toggle gridlines #3805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
wzhudev
changed the title
feat: implement render config mechanism
feat: implement render config mechanism and gridline visiblility
Oct 21, 2024
wzhudev
changed the title
feat: implement render config mechanism and gridline visiblility
feat: gridline visiblilty
Oct 21, 2024
wzhudev
requested review from
jikkai,
Jocs,
ybzky,
yuhongz,
Gggpound,
VicKun4937,
Dushusir,
hexf00,
siam-ese and
lumixraku
as code owners
October 21, 2024 11:17
lumixraku
reviewed
Oct 22, 2024
lumixraku
approved these changes
Oct 22, 2024
zhaolixin7
added
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
and removed
qa:untested
This PR is ready to be tested
labels
Oct 22, 2024
wzhudev
force-pushed
the
wzhudev/feat/sheet-grid-line
branch
from
October 23, 2024 00:24
9445c9d
to
6882663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
Pull Request Checklist