Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets): toggle gridlines #3805

Merged
merged 17 commits into from
Oct 23, 2024
Merged

feat(sheets): toggle gridlines #3805

merged 17 commits into from
Oct 23, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 19, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev
Copy link
Member Author

wzhudev commented Oct 19, 2024

WXWorkCapture_17293317254663

Toggling grid line would be implemented on top of this, and themes in the future.

Copy link

github-actions bot commented Oct 19, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  bc9ac93
info  For more information, see full report

@wzhudev wzhudev changed the title feat: implement render config mechanism feat: implement render config mechanism and gridline visiblility Oct 21, 2024
@wzhudev wzhudev changed the title feat: implement render config mechanism and gridline visiblility feat: gridline visiblilty Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 5.31915% with 89 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (42e26e1) to head (bc9ac93).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/core/src/services/config/config.service.ts 0.00% 18 Missing ⚠️
...s/sheets-ui/src/controllers/menu/gridlines.menu.ts 0.00% 17 Missing ⚠️
...ngine-render/src/services/render-config.service.ts 0.00% 10 Missing ⚠️
.../src/commands/commands/toggle-gridlines.command.ts 0.00% 10 Missing ⚠️
packages/facade/src/apis/sheets/f-worksheet.ts 0.00% 8 Missing ⚠️
...rc/commands/mutations/toggle-gridlines.mutation.ts 0.00% 8 Missing ⚠️
...lers/render-controllers/sheet.render-controller.ts 0.00% 7 Missing ⚠️
...s/sheets-ui/src/controllers/sheet-ui.controller.ts 0.00% 3 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/plugin.ts 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3805      +/-   ##
==========================================
- Coverage   31.97%   31.97%   -0.01%     
==========================================
  Files        2341     2343       +2     
  Lines      120979   121010      +31     
  Branches    26778    26780       +2     
==========================================
  Hits        38689    38689              
- Misses      82290    82321      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review October 21, 2024 11:17
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Oct 21, 2024
@wzhudev wzhudev changed the title feat: gridline visiblilty feat(sheets): toggle gridlines Oct 21, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 22, 2024
@wzhudev wzhudev force-pushed the wzhudev/feat/sheet-grid-line branch from 9445c9d to 6882663 Compare October 23, 2024 00:24
@wzhudev wzhudev merged commit c3a7ddf into dev Oct 23, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/feat/sheet-grid-line branch October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants