Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): the apply result should be consistent #3806

Merged
merged 5 commits into from
Oct 22, 2024
Merged

fix(docs): the apply result should be consistent #3806

merged 5 commits into from
Oct 22, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 19, 2024

close https://github.com/dream-num/univer-pro/issues/2943

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 19, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 10 seconds
commit  16b4235
info  For more information, see full report

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (65cb1c5) to head (16b4235).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/basics/paragraph.ts 0.00% 8 Missing ⚠️
...rollers/render-controllers/doc-input.controller.ts 0.00% 7 Missing ⚠️
...docs-ui/src/commands/commands/ime-input.command.ts 0.00% 6 Missing ⚠️
...ers/render-controllers/doc-ime-input.controller.ts 0.00% 3 Missing ⚠️
...s-ui/src/commands/commands/core-editing.command.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3806      +/-   ##
==========================================
+ Coverage   31.91%   31.97%   +0.05%     
==========================================
  Files        2338     2338              
  Lines      120850   120841       -9     
  Branches    26750    26748       -2     
==========================================
+ Hits        38573    38640      +67     
+ Misses      82277    82201      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review October 22, 2024 09:23
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 22, 2024
@Jocs Jocs requested a review from weird94 October 22, 2024 09:24
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 22, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 22, 2024
@Jocs Jocs merged commit d0054f3 into dev Oct 22, 2024
9 checks passed
@Jocs Jocs deleted the fix/apply-issue branch October 22, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants