Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix CELL_INVERTED_INDEX_CACHE range set #3807

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

wpxp123456
Copy link
Contributor

close #3772

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 19, 2024
Copy link

github-actions bot commented Oct 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 19, 2024

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 24 seconds
commit  dd7c319
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 89.58333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 32.09%. Comparing base (ebcf3e0) to head (dd7c319).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...mula/src/engine/value-object/array-value-object.ts 90.12% 8 Missing ⚠️
.../engine-formula/src/basics/inverted-index-cache.ts 89.09% 6 Missing ⚠️
...s/engine-formula/src/functions/logical/if/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3807      +/-   ##
==========================================
+ Coverage   32.07%   32.09%   +0.01%     
==========================================
  Files        2322     2322              
  Lines      120220   120281      +61     
  Branches    26603    26617      +14     
==========================================
+ Hits        38561    38602      +41     
- Misses      81659    81679      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 21, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 21, 2024
@univer-bot univer-bot bot removed the qa:rejected label Oct 21, 2024
@DR-Univer DR-Univer merged commit 1092fcb into dev Oct 22, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix/formula-cell-inverted-index-cache branch October 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] formula if issue
3 participants