-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sheet): styles on rows and columns #3816
Conversation
View Deployment
|
Playwright test resultsDetails 18 tests across 8 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3816 +/- ##
==========================================
- Coverage 32.06% 31.89% -0.18%
==========================================
Files 2322 2341 +19
Lines 120245 120980 +735
Branches 26608 26774 +166
==========================================
+ Hits 38562 38588 +26
- Misses 81683 82392 +709 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, though some code readability issues need to addressed.
packages/sheets/src/commands/mutations/set-worksheet-default-style.mutations.ts
Outdated
Show resolved
Hide resolved
packages/sheets/src/commands/mutations/set-worksheet-row-column-style.mutation.ts
Show resolved
Hide resolved
packages/sheets/src/services/sheet-interceptor/sheet-interceptor.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
document Pull request: https://github.com/dream-num/univer.ai/pull/332
facade API:
Using in workbook Data: