-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thread-comment): didn't show tips on merge-cell comment #3819
Conversation
View Deployment
|
Playwright test resultsDetails 17 tests across 8 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3819 +/- ##
==========================================
- Coverage 32.06% 32.04% -0.03%
==========================================
Files 2322 2322
Lines 120245 120275 +30
Branches 26608 26623 +15
==========================================
- Hits 38562 38537 -25
- Misses 81683 81738 +55 ☔ View full report in Codecov by Sentry. |
if (!skeleton) { | ||
return; | ||
} | ||
|
||
if (!range) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if-return should comes before L66. BTW, can a selection has no range?
close https://github.com/dream-num/univer-pro/issues/2707
Pull Request Checklist