Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thread-comment): didn't show tips on merge-cell comment #3819

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 22, 2024

close https://github.com/dream-num/univer-pro/issues/2707

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 22, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 9 seconds
commit  7286646
info  For more information, see full report

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.04%. Comparing base (192da79) to head (7286646).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...trollers/sheets-thread-comment-popup.controller.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3819      +/-   ##
==========================================
- Coverage   32.06%   32.04%   -0.03%     
==========================================
  Files        2322     2322              
  Lines      120245   120275      +30     
  Branches    26608    26623      +15     
==========================================
- Hits        38562    38537      -25     
- Misses      81683    81738      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 22, 2024
if (!skeleton) {
return;
}

if (!range) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if-return should comes before L66. BTW, can a selection has no range?

@weird94 weird94 merged commit 65cb1c5 into dev Oct 22, 2024
9 checks passed
@weird94 weird94 deleted the fix/merge-cell-comment branch October 22, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants