Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): improve layout and overflow handling in sheet bar menu #3823

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Oct 22, 2024

close #3821

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from wzhudev as a code owner October 22, 2024 07:15
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 23 seconds
commit  e71454b
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.92%. Comparing base (9630e31) to head (e71454b).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3823   +/-   ##
=======================================
  Coverage   31.92%   31.92%           
=======================================
  Files        2338     2338           
  Lines      120836   120836           
  Branches    26746    26746           
=======================================
  Hits        38575    38575           
  Misses      82261    82261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 22, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 22, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit acb4a45 into dev Oct 23, 2024
9 checks passed
@jikkai jikkai deleted the fix/sheet-bar-scroll branch October 23, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sheet bar menu cannot be scrolled
3 participants