Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing-ui): float dom scroll not update on drag range #3840

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 24, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners October 24, 2024 06:15
Copy link

github-actions bot commented Oct 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 59 seconds
commit  41cdba4
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (3e3e795) to head (41cdba4).

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 2 Missing ⚠️
packages/ui/src/views/components/dom/FloatDom.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3840   +/-   ##
=======================================
  Coverage   31.95%   31.95%           
=======================================
  Files        2349     2349           
  Lines      121163   121160    -3     
  Branches    26811    26811           
=======================================
  Hits        38719    38719           
+ Misses      82444    82441    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 575a604 into dev Oct 24, 2024
2 checks passed
@weird94 weird94 deleted the feat/float-dom-scroll branch October 24, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants