Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): supplement text formulas #3842

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Conversation

wpxp123456
Copy link
Contributor

close dream-num/univer-pro#3126

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 changed the title feat(formula): Supplement Text Formulas feat(formula): supplement text formulas Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  16e9b24
info  For more information, see full report

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.71%. Comparing base (2bea457) to head (16e9b24).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3842      +/-   ##
==========================================
+ Coverage   32.46%   32.71%   +0.25%     
==========================================
  Files        2427     2438      +11     
  Lines      126040   126494     +454     
  Branches    28193    28330     +137     
==========================================
+ Hits        40915    41380     +465     
+ Misses      85125    85114      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpxp123456 wpxp123456 force-pushed the feat/add-text-formulas branch 4 times, most recently from 9dbbb6a to 2817f8c Compare November 5, 2024 06:37
@wpxp123456 wpxp123456 force-pushed the feat/add-text-formulas branch from 36d1761 to 16e9b24 Compare November 5, 2024 08:20
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 5, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 5, 2024
@wpxp123456 wpxp123456 merged commit 114f6dc into dev Nov 5, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/add-text-formulas branch November 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants