Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): set inline style at cursor #3846

Merged
merged 3 commits into from
Oct 24, 2024
Merged

feat(docs): set inline style at cursor #3846

merged 3 commits into from
Oct 24, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 24, 2024

close https://github.com/dream-num/univer-pro/issues/2979

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review October 24, 2024 09:29
@Jocs Jocs requested a review from weird94 October 24, 2024 09:29
Copy link

github-actions bot commented Oct 24, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  4 minutes, 55 seconds
commit  1cefa80
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-gridlines.spec.ts › sheets no gridlines

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 39.02439% with 25 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (d642327) to head (1cefa80).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/docs-ui/src/services/doc-menu-style.service.ts 55.55% 8 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 5 Missing ⚠️
...rollers/render-controllers/doc-input.controller.ts 0.00% 4 Missing ⚠️
packages/docs-ui/src/basics/paragraph.ts 0.00% 3 Missing ⚠️
...docs-ui/src/commands/commands/ime-input.command.ts 0.00% 3 Missing ⚠️
...-ui/src/commands/commands/inline-format.command.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3846   +/-   ##
=======================================
  Coverage   31.97%   31.97%           
=======================================
  Files        2349     2350    +1     
  Lines      121179   121203   +24     
  Branches    26821    26822    +1     
=======================================
+ Hits        38746    38755    +9     
- Misses      82433    82448   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit caed6de into dev Oct 24, 2024
9 checks passed
@Jocs Jocs deleted the fix/textrun-transform branch October 24, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants