Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix sumif formula range and sumRange different dimensions #3853

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Oct 25, 2024

close #3772

第一个参数和第三个参数维度不同,可以测几个case看一下
现在有个问题:第三个参数会扩展到和第一个参数范围相同,但扩展的范围内单元格值改变,因这个单元格不在公式参数选区范围内,不会触发公式的重新计算,现在google和飞书是这样的,但excel和葡萄城可以触发,所以这点待后面看怎么处理

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 mentioned this pull request Oct 25, 2024
2 tasks
Copy link

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  7411e69
info  For more information, see full report

@univer-bot
Copy link

univer-bot bot commented Oct 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): fix sumif formula range and sumRange different dimensions

Title: fix(formula): fix sumif formula range and sumRange different dimensions


close #3772

The first parameter and the third parameter have different dimensions. You can test a few cases and take a look.
Now there is a problem: the third parameter will be expanded to the same range as the first parameter, but the cell value changes within the expanded range. Because this cell is not within the formula parameter selection range, it will not trigger the recalculation of the formula. Now This is the case for Google and Feishu, but it can be triggered by Excel and Grape City, so we will see how to deal with this later.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.96%. Comparing base (e351a55) to head (7411e69).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3853      +/-   ##
==========================================
+ Coverage   31.95%   31.96%   +0.01%     
==========================================
  Files        2351     2351              
  Lines      121302   121318      +16     
  Branches    26850    26851       +1     
==========================================
+ Hits        38756    38777      +21     
+ Misses      82546    82541       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 26, 2024
@wpxp123456 wpxp123456 merged commit faf7936 into dev Oct 26, 2024
11 checks passed
@wpxp123456 wpxp123456 deleted the fix/formula-sumif branch October 26, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] formula if issue
3 participants