Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): default text style in doc #3906

Merged
merged 3 commits into from
Nov 1, 2024
Merged

fix(docs): default text style in doc #3906

merged 3 commits into from
Nov 1, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 31, 2024

close https://github.com/dream-num/univer-pro/issues/3052
close https://github.com/dream-num/univer-pro/issues/2835

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review October 31, 2024 07:19
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 31, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  f4b020f
info  For more information, see full report

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 39 lines in your changes missing coverage. Please review.

Project coverage is 32.30%. Comparing base (51f1616) to head (f4b020f).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/docs-ui/src/services/doc-menu-style.service.ts 30.00% 14 Missing ⚠️
packages/docs-ui/src/basics/paragraph.ts 0.00% 8 Missing ⚠️
...docs-ui/src/commands/commands/ime-input.command.ts 0.00% 6 Missing ⚠️
...ocs-ui/src/commands/commands/break-line.command.ts 0.00% 5 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 4 Missing ⚠️
...rollers/render-controllers/doc-input.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3906      +/-   ##
==========================================
- Coverage   32.31%   32.30%   -0.01%     
==========================================
  Files        2456     2456              
  Lines      125858   125903      +45     
  Branches    28104    28113       +9     
==========================================
+ Hits        40672    40677       +5     
- Misses      85186    85226      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

在不同字号的内容A后使用换行,新输入的内容预期应该跟内容A的字号&文本格式一致
2024_10_31 16_52_58 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 31, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Use line breaks after content A with different font sizes. The newly entered content is expected to be consistent with the font size & text format of content A.
2024_10_31 16_52_58 video.webm

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Oct 31, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 1, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 1, 2024
@Jocs Jocs merged commit b7937cd into dev Nov 1, 2024
9 checks passed
@Jocs Jocs deleted the fix/default-font-style branch November 1, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants