Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): the data bar is rendered with a color po… #3934

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Nov 2, 2024

…cket

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 2, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 41 seconds
commit  83a5e8d
info  For more information, see full report

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.33%. Comparing base (1dfbd10) to head (83a5e8d).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...formatting/src/services/calculate-unit/data-bar.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3934      +/-   ##
==========================================
- Coverage   32.34%   32.33%   -0.02%     
==========================================
  Files        2457     2458       +1     
  Lines      125883   125933      +50     
  Branches    28107    28127      +20     
==========================================
  Hits        40717    40717              
- Misses      85166    85216      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound merged commit 626c9b8 into dev Nov 4, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-data-bar-1102 branch November 4, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants