Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing of number formats should be done in plugins #3959

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Nov 5, 2024

close #3741

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from Jocs as a code owner November 5, 2024 09:18
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 5, 2024
@ybzky ybzky requested a review from Gggpound November 5, 2024 09:19
Copy link

github-actions bot commented Nov 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 41 seconds
commit  d8a5122
info  For more information, see full report

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.71%. Comparing base (39d0d46) to head (d8a5122).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...fmt-ui/src/controllers/numfmt.editor.controller.ts 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3959      +/-   ##
==========================================
+ Coverage   32.46%   32.71%   +0.25%     
==========================================
  Files        2427     2439      +12     
  Lines      126046   126546     +500     
  Branches    28196    28345     +149     
==========================================
+ Hits        40915    41396     +481     
- Misses      85131    85150      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Nov 5, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in this PR should have test to cover. It seems that there are a lot of if conditions.

The title of this PR should be more specific.

@ybzky ybzky changed the title fix: fix numfmt without plugin fix: parsing of number formats should be done in plugins Nov 6, 2024
@ybzky ybzky requested a review from wzhudev November 6, 2024 11:43
ts: {
ff: 'Arial',
fs: 11,
bl: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer use BooleanNumber.TRUE ?

@ybzky ybzky merged commit fe60a29 into dev Nov 7, 2024
9 checks passed
@ybzky ybzky deleted the fix-numfmt-without-plugin branch November 7, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants