-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing of number formats should be done in plugins #3959
Conversation
View Deployment
|
Playwright test resultsDetails
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3959 +/- ##
==========================================
+ Coverage 32.46% 32.71% +0.25%
==========================================
Files 2427 2439 +12
Lines 126046 126546 +500
Branches 28196 28345 +149
==========================================
+ Hits 40915 41396 +481
- Misses 85131 85150 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in this PR should have test to cover. It seems that there are a lot of if
conditions.
The title of this PR should be more specific.
ts: { | ||
ff: 'Arial', | ||
fs: 11, | ||
bl: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer use BooleanNumber.TRUE
?
close #3741
Pull Request Checklist