Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links pasted into cells require paragraph attributes #3980

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Nov 6, 2024

close https://github.com/dream-num/univer-pro/issues/2740

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner November 6, 2024 13:15
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 6, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  08c3df2
info  For more information, see full report

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.70%. Comparing base (2272eae) to head (08c3df2).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3980   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files        2439     2439           
  Lines      126528   126528           
  Branches    28335    28335           
=======================================
  Hits        41380    41380           
  Misses      85148    85148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Nov 7, 2024
@ybzky ybzky merged commit 69a65e8 into dev Nov 7, 2024
9 checks passed
@ybzky ybzky deleted the fix-link-paragrahps branch November 7, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants