-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(range-selector): illusion of movement #4011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
Gggpound
force-pushed
the
fix-selection-moving-1108
branch
from
November 8, 2024 10:52
9719b94
to
5440cec
Compare
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Nov 8, 2024
zhaolixin7
removed
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Nov 8, 2024
Gggpound
force-pushed
the
fix-selection-moving-1108
branch
from
November 9, 2024 01:59
2f9fe4c
to
caddba4
Compare
lumixraku
reviewed
Nov 9, 2024
packages/sheets-formula-ui/src/views/range-selector/hooks/useHighlight.ts
Show resolved
Hide resolved
lumixraku
approved these changes
Nov 9, 2024
The 'sequenceNodesBuilder' will cache the results.
Gggpound
force-pushed
the
fix-selection-moving-1108
branch
from
November 9, 2024 07:28
d1ec5b4
to
7243524
Compare
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/3170
https://github.com/dream-num/univer-pro/issues/3081
https://github.com/dream-num/univer-pro/issues/3154
https://github.com/dream-num/univer-pro/issues/3133
Pull Request Checklist