Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-selector): illusion of movement #4011

Merged
merged 6 commits into from
Nov 9, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Nov 8, 2024

close https://github.com/dream-num/univer-pro/issues/3170
https://github.com/dream-num/univer-pro/issues/3081
https://github.com/dream-num/univer-pro/issues/3154
https://github.com/dream-num/univer-pro/issues/3133

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 8, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  7243524
info  For more information, see full report

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 163 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (2006e19) to head (7243524).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...eets-formula-ui/src/views/range-selector/index.tsx 0.00% 48 Missing ⚠️
...-ui/src/views/range-selector/hooks/useHighlight.ts 0.00% 32 Missing ⚠️
...eets-formula-ui/src/views/formula-editor/index.tsx 0.00% 28 Missing ⚠️
...views/range-selector/hooks/useFirstHighlightDoc.ts 0.00% 23 Missing ⚠️
...ws/range-selector/hooks/useSheetSelectionChange.ts 0.00% 15 Missing ⚠️
...ws/formula-editor/hooks/useSheetSelectionChange.ts 0.00% 11 Missing ⚠️
.../src/views/range-selector/hooks/useFormulaToken.ts 0.00% 3 Missing ⚠️
...c/views/formula-editor/hooks/useFormulaDescribe.ts 0.00% 1 Missing ⚠️
.../src/views/formula-editor/hooks/useSelectionAdd.ts 0.00% 1 Missing ⚠️
...ula-ui/src/views/range-selector/hooks/useVerify.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4011   +/-   ##
=======================================
  Coverage   32.84%   32.85%           
=======================================
  Files        2501     2501           
  Lines      126559   126542   -17     
  Branches    28343    28341    -2     
=======================================
  Hits        41571    41571           
+ Misses      84988    84971   -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 8, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 8, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 8, 2024
@zhaolixin7 zhaolixin7 removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 8, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 8, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 9, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 9, 2024
@Gggpound Gggpound merged commit 02b335c into dev Nov 9, 2024
10 checks passed
@Gggpound Gggpound deleted the fix-selection-moving-1108 branch November 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants