Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): table wrap layout type #4021

Merged
merged 6 commits into from
Nov 12, 2024
Merged

feat(render-engine): table wrap layout type #4021

merged 6 commits into from
Nov 12, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 9, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 9, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  b77e4f3
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 2.25989% with 173 lines in your changes missing coverage. Please review.

Project coverage is 32.93%. Comparing base (9040e5f) to head (47685b4).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 79 Missing ⚠️
...e-render/src/components/docs/layout/block/table.ts 0.00% 58 Missing ⚠️
...ne-render/src/components/docs/layout/model/line.ts 0.00% 20 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 8 Missing ⚠️
...onents/docs/layout/block/paragraph/linebreaking.ts 0.00% 5 Missing ⚠️
...c/components/docs/extensions/font-and-base-line.ts 0.00% 2 Missing ⚠️
...cs-ui/src/services/selection/convert-rect-range.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4021      +/-   ##
==========================================
+ Coverage   32.86%   32.93%   +0.07%     
==========================================
  Files        2501     2494       -7     
  Lines      126589   126810     +221     
  Branches    28350    28397      +47     
==========================================
+ Hits        41598    41766     +168     
- Misses      84991    85044      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 36 seconds
commit  47685b4
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@Jocs Jocs marked this pull request as ready for review November 12, 2024 13:06
@Jocs Jocs merged commit 1762023 into dev Nov 12, 2024
13 checks passed
@Jocs Jocs deleted the feat/table-align branch November 12, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants