Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-selector): focus after confirm #4029

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 11, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  3cd3822
info  For more information, see full report

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (c429541) to head (3cd3822).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...eets-formula-ui/src/views/range-selector/index.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4029   +/-   ##
=======================================
  Coverage   32.85%   32.85%           
=======================================
  Files        2501     2501           
  Lines      126575   126594   +19     
  Branches    28347    28350    +3     
=======================================
+ Hits        41584    41598   +14     
- Misses      84991    84996    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 12, 2024
@Gggpound Gggpound merged commit 0e5bd85 into dev Nov 12, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-range-selector-1111 branch November 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants