Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): optimize data-validation error msg #4044

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 12, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 12, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 37 seconds
commit  a644df4
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 32.93%. Comparing base (27eb2d4) to head (a644df4).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ata-validation/src/validators/decimal-validator.ts 0.00% 9 Missing ⚠️
...ages/sheets-data-validation/src/validators/util.ts 0.00% 9 Missing ⚠️
...-data-validation/src/validators/whole-validator.ts 0.00% 8 Missing ⚠️
...s-data-validation/src/validators/date-validator.ts 0.00% 6 Missing ⚠️
...validation/src/validators/text-length-validator.ts 0.00% 6 Missing ⚠️
...a-validation/src/validators/base-data-validator.ts 0.00% 3 Missing ⚠️
...ges/sheets-data-validation/src/validators/const.ts 0.00% 2 Missing ⚠️
...on-ui/src/views/components/date-dropdown/index.tsx 0.00% 1 Missing ⚠️
...src/controllers/dv-formula-ref-range.controller.ts 0.00% 1 Missing ⚠️
...data-validation/src/validators/custom-validator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4044      +/-   ##
==========================================
- Coverage   32.93%   32.93%   -0.01%     
==========================================
  Files        2495     2496       +1     
  Lines      126818   126832      +14     
  Branches    28398    28401       +3     
==========================================
  Hits        41766    41766              
- Misses      85052    85066      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code readability issue need to be addressed.

@weird94 weird94 requested a review from wzhudev November 13, 2024 04:39
@weird94 weird94 merged commit b4d4cfa into dev Nov 13, 2024
9 checks passed
@weird94 weird94 deleted the feat/optimize-data-validation-error-msg branch November 13, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants