Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-thread-comment): disable undo redo on docs comment #4047

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 13, 2024

close https://github.com/dream-num/univer-pro/issues/3071

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 13, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 37 seconds
commit  adbed12
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 32.92%. Comparing base (b4d4cfa) to head (adbed12).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...data-model/text-x/build-utils/custom-decoration.ts 0.00% 26 Missing ⚠️
...es/docs-ui/src/basics/custom-decoration-factory.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4047      +/-   ##
==========================================
- Coverage   32.93%   32.92%   -0.01%     
==========================================
  Files        2496     2497       +1     
  Lines      126832   126845      +13     
  Branches    28401    28403       +2     
==========================================
+ Hits        41766    41767       +1     
- Misses      85066    85078      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit a7a5201 into dev Nov 13, 2024
9 checks passed
@weird94 weird94 deleted the feat/comment-undo branch November 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants